Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change rbac url to alias #19070

Merged
merged 1 commit into from
Feb 11, 2020
Merged

Change rbac url to alias #19070

merged 1 commit into from
Feb 11, 2020

Conversation

zacharysarah
Copy link
Contributor

This PR fixes #19068.

/assign @tengqm

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 11, 2020
@tengqm
Copy link
Contributor

tengqm commented Feb 11, 2020

/lgtm
Pending approval for CI.

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Feb 11, 2020
@netlify
Copy link

netlify bot commented Feb 11, 2020

Deploy preview for kubernetes-io-master-staging ready!

Built with commit cfe3004

https://deploy-preview-19070--kubernetes-io-master-staging.netlify.com

@tengqm
Copy link
Contributor

tengqm commented Feb 11, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 11, 2020
@k8s-ci-robot k8s-ci-robot merged commit d4437d5 into kubernetes:master Feb 11, 2020
zacharysarah added a commit to zacharysarah/website that referenced this pull request Feb 21, 2020
@zacharysarah
Change url to alias (kubernetes#19070)
13401fe
wawa0210 pushed a commit to wawa0210/website that referenced this pull request Mar 2, 2020
@zacharysarah @wawa0210
Change url to alias (kubernetes#19070)
ae7d39f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@tengqm tengqm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broken link for RBAC
3 participants
@zacharysarah @tengqm @k8s-ci-robot